Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integrations tests workflow #63

Closed
wants to merge 1 commit into from

Conversation

kellertuer
Copy link
Member

Currently this integration test covers Manifolds.jl
It extends tests in time by quite a bit, but on the other hand, this package is not PR'ed that often and if so we want to be sure it does not break Manifolds.jl.

This resolves #58.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@fa09b2a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   99.69%           
=========================================
  Files             ?       10           
  Lines             ?     1302           
  Branches          ?        0           
=========================================
  Hits              ?     1298           
  Misses            ?        4           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa09b2a...f1d4626. Read the comment docs.

@kellertuer kellertuer closed this Apr 18, 2021
@kellertuer kellertuer reopened this Apr 18, 2021
@kellertuer
Copy link
Member Author

Python seems to be missing...hm.

@mateuszbaran
Copy link
Member

That's a really weird issue... maybe let's just merge it and hope it goes away soon? I have no idea what could cause that.

@kellertuer
Copy link
Member Author

I think the problem with this integration is indeed that it takes far too long (i.e. while ManifoldsBase itself takes 5-8 minutes this would run 55+ minutes), I would prefer to maybe have a miniminimal test over on Manifolds for integration testing? I will close this one for now until we have a good idea.

@kellertuer kellertuer closed this Apr 1, 2022
@mateuszbaran
Copy link
Member

Yes, having a reduced set of tests would make sense but we can leave it for later.

@kellertuer kellertuer deleted the kellertuer/integration-test branch May 4, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test with Manifolds
2 participants